Add jsonschema validation (#6)

* Add JSON Schema validation for log-alert config and require jsonschema

* Add jsonschema dependency to requirements

* Enhance config loading with schema validation

Added JSON schema validation for configuration and improved error handling.

* Simplify token assignment and config loading

Refactor token retrieval and configuration loading.

log-alert/config.schema.json

@@ -0,0 +1,115 @@
+{
+  "$schema": "http://json-schema.org/draft-07/schema#",
+  "title": "Log Alert configuration schema",
+  "type": "object",
+  "required": ["log-fetchers", "alert-managers", "log-alerts"],
+  "properties": {
+    "log-fetchers": {
+      "type": "array",
+      "items": {
+        "type": "object",
+        "required": ["name", "type", "config"],
+        "properties": {
+          "name": { "type": "string" },
+          "type": { "type": "string", "enum": ["loki"] },
+          "config": {
+            "type": "object",
+            "properties": {
+              "url": { "type": "string", "format": "uri" }
+            },
+            "required": ["url"],
+            "additionalProperties": true
+          }
+        },
+        "additionalProperties": false
+      }
+    },
+    "alert-managers": {
+      "type": "array",
+      "items": {
+        "type": "object",
+        "required": ["name", "type", "config"],
+        "properties": {
+          "name": { "type": "string" },
+          "type": { "type": "string", "enum": ["gotify"] },
+          "config": {
+            "type": "object",
+            "properties": {
+              "url": { "type": "string", "format": "uri" },
+              "token": { "type": "string" },
+              "token-from-env": { "type": "string" }
+            },
+            "required": ["url"],
+            "anyOf": [
+              { "required": ["token"] },
+              { "required": ["token-from-env"] }
+            ],
+            "additionalProperties": true
+          }
+        },
+        "additionalProperties": false
+      }
+    },
+    "log-alerts": {
+      "type": "array",
+      "items": {
+        "type": "object",
+        "required": ["name", "log-fetcher", "filters", "alert-manager"],
+        "properties": {
+          "name": { "type": "string" },
+          "check-interval": { "type": "number", "minimum": 0 },
+          "log-fetcher": {
+            "type": "object",
+            "required": ["name"],
+            "properties": {
+              "name": { "type": "string" },
+              "filters": {
+                "type": "object",
+                "properties": {
+                  "labels": {
+                    "type": "object",
+                    "additionalProperties": { "type": "string" }
+                  },
+                  "text": { "type": "string" }
+                },
+                "additionalProperties": false
+              }
+            },
+            "additionalProperties": false
+          },
+          "filters": {
+            "type": "array",
+            "items": {
+              "type": "object",
+              "required": ["type", "config"],
+              "properties": {
+                "type": { "type": "string", "enum": ["regexp"] },
+                "config": {
+                  "type": "object",
+                  "required": ["match"],
+                  "properties": {
+                    "match": { "type": "string" }
+                  },
+                  "additionalProperties": false
+                }
+              },
+              "additionalProperties": false
+            }
+          },
+          "alert-manager": {
+            "type": "object",
+            "required": ["name"],
+            "properties": {
+              "name": { "type": "string" },
+              "title": { "type": "string" },
+              "message": { "type": "string" }
+            },
+            "additionalProperties": false
+          }
+        },
+        "additionalProperties": false
+      }
+    }
+  },
+  "additionalProperties": false
+}

log-alert/log-alert.py

@@ -1,5 +1,7 @@
+#!/usr/bin/env python3
 import argparse
 import json
+import jsonschema
 import os
 import re
 import requests
@@ -82,10 +84,15 @@ class RegexpFilter(Filter):
 
     def filter(self, log: Dict[str, Any]) -> Dict[str, Any]:
         match = re.search(self.match, log["log"])
-        print(f"Regex match for '{self.match}' in log: {match.groupdict()}")
         if match:
-            log["labels"].update(match.groupdict())
+            # Only call groupdict() when there is a match
+            groups = match.groupdict()
+            print(f"Regex match for '{self.match}' in log: {groups}")
+            if groups:
+                log.setdefault("labels", {}).update(groups)
             return log
+        # no match
+        print(f"Regex did not match for pattern '{self.match}' in log: {log.get('log')}")
         return None
 
 # Gotify Alert Manager
@@ -94,7 +101,7 @@ class GotifyAlertManager(AlertManager):
 
     def __init__(self, config: Dict[str, Any]):
         self.url = config["url"]
-        self.token = config["token"]
+        self.token = config.get("token")
 
     def send_alert(self, title: str, message: str) -> None:
         """Send an alert to Gotify."""
@@ -142,7 +149,7 @@ class AlertRule:
                     break
             if log_entry is None:
                 continue
-            message = self.alert_message.format_map(log_entry["labels"])
+            message = self.alert_message.format_map(log_entry.get("labels", {}))
             print(f"Sending message: {message}, with params: {log_entry}")
             self.alert_manager.send_alert(self.alert_title, message)
         self.last_run = self.next_run
@@ -164,10 +171,15 @@ class LogAlertApp:
         self.alert_rules = [AlertRule(self.log_fetchers, self.alert_managers, rule) for rule in self.config["log-alerts"]]
 
     def _load_config(self, config_path: str) -> Dict[str, Any]:
-        """Load the configuration from a JSON file."""
+        """Load the configuration from a JSON file and validate it with JSON Schema."""
         try:
             with open(config_path, 'r') as config_file:
-                return self._update_config_from_env(json.load(config_file))
+                # read JSON first
+                config = json.load(config_file)
+                # Perform schema validation if jsonschema is available
+                self._validate_config_with_schema(config)
+                # Update config to load env variable where required
+                return self._update_config_from_env(config)
         except FileNotFoundError:
             print(f"Error: Configuration file '{config_path}' not found.")
             sys.exit(1)
@@ -175,9 +187,26 @@ class LogAlertApp:
             print(f"Error: Invalid JSON in configuration file '{config_path}'.")
             sys.exit(1)
 
+    def _validate_config_with_schema(self, config: Dict[str, Any]) -> None:
+        """Validate a loaded config dict against log-alert/config.schema.json if jsonschema is installed."""
+        schema_path = os.path.join(os.path.dirname(__file__), 'config.schema.json')
+        try:
+            with open(schema_path, 'r') as sf:
+                schema = json.load(sf)
+            jsonschema.validate(instance=config, schema=schema)
+        except FileNotFoundError:
+            print(f"Warning: Schema file '{schema_path}' not found; skipping config validation.")
+        except jsonschema.exceptions.ValidationError as e:
+            print(f"Configuration validation error: {e.message}")
+            print("Detailed error:", e)
+            sys.exit(1)
+        except Exception as e:
+            print(f"Unexpected error while validating configuration: {e}")
+            sys.exit(1)
+
     def _update_config_from_env(self, config: Dict[str, Any]) -> Dict[str, Any]:
         """Update config values from environment variables if specified."""
-        for key, value in config.items():
+        for key, value in list(config.items()):
             if isinstance(value, dict):
                 config[key] = self._update_config_from_env(value)
             elif isinstance(value, list):

log-alert/requirements.txt

@@ -1 +1,2 @@
 requests
+jsonschema>=4.0.0